[ldv-project] [PATCH 09/21] dw_dmac: remove inline marking of EXPORT_SYMBOL functions
Andy Shevchenko
andy.shevchenko at gmail.com
Fri May 10 19:24:08 MSK 2013
Seems those inlines are leftovers from first versions of the driver.
Anyway, looks fine by me. I think Viresh can give you an Ack.
9.5.2013 12.22 "Denis Efremov" <yefremov.denis at gmail.com> kirjoitti:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis at gmail.com>
> ---
> drivers/dma/dw_dmac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 43a5329..a526bb9 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -574,14 +574,14 @@ static void dwc_handle_error(struct dw_dma *dw,
> struct dw_dma_chan *dwc)
>
> /* --------------------- Cyclic DMA API extensions -------------------- */
>
> -inline dma_addr_t dw_dma_get_src_addr(struct dma_chan *chan)
> +dma_addr_t dw_dma_get_src_addr(struct dma_chan *chan)
> {
> struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
> return channel_readl(dwc, SAR);
> }
> EXPORT_SYMBOL(dw_dma_get_src_addr);
>
> -inline dma_addr_t dw_dma_get_dst_addr(struct dma_chan *chan)
> +dma_addr_t dw_dma_get_dst_addr(struct dma_chan *chan)
> {
> struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
> return channel_readl(dwc, DAR);
> --
> 1.8.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://linuxtesting.org/pipermail/ldv-project/attachments/20130510/d5b88a4c/attachment.html>
More information about the ldv-project
mailing list