[ldv-project] [PATCH] USB: cdc-acm: fix double usb_autopm_put_interface() in acm_port_activate()

Oliver Neukum oliver at neukum.org
Sat Apr 12 22:39:00 MSK 2014


On Sat, 2014-04-12 at 02:10 +0400, Alexey Khoroshilov wrote:
> If acm_submit_read_urbs() fails in acm_port_activate(), error handling
> code calls usb_autopm_put_interface() while it is already called
> before acm_submit_read_urbs(). The patch reorganizes error handling code
> to avoid double decrement of USB interface's PM-usage counter.
> 
> Found by Linux Driver Verification project (linuxtesting.org).

Nice catch.

> Signed-off-by: Alexey Khoroshilov <khoroshilov at ispras.ru>
Acked-by: Oliver Neukum <oliver at neukum.org>





More information about the ldv-project mailing list