[ldv-project] [PATCH] ufs: fix deadlocks after mutex merge
Al Viro
viro at ZenIV.linux.org.uk
Tue Sep 2 03:13:07 MSK 2014
On Tue, Sep 02, 2014 at 12:08:35AM +0100, Al Viro wrote:
> Your commit message makes no sense - ufs_evict_inode() is *never* called
> with that lock held, for one thing. I agree that "ufs: sb mutex merge +
> mutex_destroy" was been badly broken and apparently never tested, though -
> the bugs are real.
>
> Please, write a saner commit message; what happens is that
> ufs_{new,free}_inode() take the damn lock themselves these days, so
> their caller shouldn't do that.
PS: after rereading your mail, I see what you meant to say, but it really
wasn't clear enough. The crucial part is that the lock is *always* taken
by free/new, not that some of the callers take it and some do not.
More information about the ldv-project
mailing list