[ldv-project] Deadlock in pch_udc_svc_ur_interrupt()

[Alexey Khoroshilov]

Dear colleagus,

It seems code handling USB_RESET interrupt contains unavoidable deadlock.

pch_udc_isr() locks dev->lock, then calls to pch_udc_dev_isr(dev, dev_intr)
that seems to have a couple of locks dev->lock itself:

pch_udc_isr()
  spin_lock(&dev->lock);
  pch_udc_dev_isr(dev, dev_intr);
    pch_udc_svc_ur_interrupt(dev);
      empty_req_queue(ep);
        complete_req(ep, req, -ESHUTDOWN);
          spin_lock(&dev->lock);                  <--- deadlock
      if (dev->driver) { spin_lock(&dev->lock); } <--- deadlock

Found by Linux Driver Verification project (linuxtesting.org).

--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org