[ldv-project] [PATCH] usb: ehci-orion: Handle errors of clk_prepare_enable() in probe

Andrew Lunn andrew at lunn.ch
Wed Aug 25 20:33:09 MSK 2021


On Wed, Aug 25, 2021 at 08:09:02PM +0300, Evgeny Novikov wrote:
> ehci_orion_drv_probe() did not account for possible errors of
> clk_prepare_enable()

Hi Evgeny

Your patch looks good.

Reviewed-by: Andrew Lunn <andrew at lunn.ch>

At the time this was added, clk_prepare_enable() could not actually
fail, the clocks are built in, there was no error path that could
trigger. I've no idea if this is still true, so please do have this
patch merged.

      Andrew



More information about the ldv-project mailing list