[ldv-project] [PATCH] clk/ti/adpll: remove useless comparison in ti_adpll_free_resources()

Andrey Strachuk strochuk at ispras.ru
Tue Jul 19 13:23:19 MSK 2022


Local variable 'ac' is initialized by an address
of field of ti_adpll_data, so it does not make
sense to compare 'ac' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <strochuk at ispras.ru>
Fixes: 21330497f303 ("clk: ti: Add support for dm814x ADPLL")
---
 drivers/clk/ti/adpll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index 962502ca7ff0..7207915f9440 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -772,7 +772,7 @@ static void ti_adpll_free_resources(struct ti_adpll_data *d)
 	for (i = TI_ADPLL_M3; i >= 0; i--) {
 		struct ti_adpll_clock *ac = &d->clocks[i];
 
-		if (!ac || IS_ERR_OR_NULL(ac->clk))
+		if (IS_ERR_OR_NULL(ac->clk))
 			continue;
 		if (ac->cl)
 			clkdev_drop(ac->cl);
-- 
2.25.1




More information about the ldv-project mailing list