[lvc-project] [PATCH v2 2/2] MIPS: BCM63xx: Add check for NULL for clk in clk_enable

Anastasia Belova abelova at astralinux.ru
Wed Dec 7 17:28:24 MSK 2022


Errors from previous version of patch fixed.
Check clk for NULL before calling clk_enable_unlocked where clk
is dereferenced. There is such check in other implementations
of clk_enable.

Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
Reported-by: kernel test robot <lkp at intel.com>
Signed-off-by: Anastasia Belova <abelova at astralinux.ru>
---
 arch/mips/bcm63xx/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index 401140cf36d9..cf303d6e6693 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -362,7 +362,7 @@ static struct clk clk_periph = {
 int clk_enable(struct clk *clk)
 {
 	if (!clk)
-		return;
+		return 0;
 
 	mutex_lock(&clocks_mutex);
 	clk_enable_unlocked(clk);
-- 
2.30.2




More information about the lvc-project mailing list