[lvc-project] [PATCH v2] scsi/cxgbi/libcxgbi: make sure sg is present before calling sg_next()

Daniil Tatianin d-tatianin at yandex-team.ru
Mon Nov 14 18:09:23 MSK 2022


sg_next() dereferences the passed sg, therefore we have to verify that
it's present before calling it.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Signed-off-by: Daniil Tatianin <d-tatianin at yandex-team.ru>
---
 drivers/scsi/cxgbi/libcxgbi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index af281e271f88..2ff9810f42a9 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -1196,8 +1196,7 @@ void cxgbi_ddp_set_one_ppod(struct cxgbi_pagepod *ppod,
 
 	if (offset == len) {
 		offset = 0;
-		sg = sg_next(sg);
-		if (sg) {
+		if (sg && (sg = sg_next(sg))) {
 			addr = sg_dma_address(sg);
 			len = sg_dma_len(sg);
 		}
-- 
2.25.1




More information about the lvc-project mailing list