[lvc-project] [PATCH v2 3/3] net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers

[Daniil Tatianin]

On 11/30/22 4:51 PM, Andrew Lunn wrote:
> On Tue, Nov 29, 2022 at 06:39:41PM -0800, Jakub Kicinski wrote:
>> On Wed, 30 Nov 2022 01:25:06 +0100 Andrew Lunn wrote:
>>> On Tue, Nov 29, 2022 at 01:38:01PM +0300, Daniil Tatianin wrote:
>>>> So that it's easier to follow and make sense of the branching and
>>>> various conditions.
>>>>
>>>> Stats retrieval has been split into two separate functions
>>>> ethtool_get_phy_stats_phydev & ethtool_get_phy_stats_ethtool.
>>>> The former attempts to retrieve the stats using phydev & phy_ops, while
>>>> the latter uses ethtool_ops.
>>>>
>>>> Actual n_stats validation & array allocation has been moved into a new
>>>> ethtool_vzalloc_stats_array helper.
>>>>
>>>> This also fixes a potential NULL dereference of
>>>> ops->get_ethtool_phy_stats where it was getting called in an else branch
>>>> unconditionally without making sure it was actually present.
>>>>
>>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE
>>>> static analysis tool.
>>>>
>>>> Signed-off-by: Daniil Tatianin <d-tatianin at yandex-team.ru>
>>>
>>> Reviewed-by: Andrew Lunn <andrew at lunn.ch>
>>
>> FWIW the patches did not hit the list, once again :/
> 
> Daniil, how are you sending the patches? git send-email?
Yup, just plain old git send-email
> You might need to contact postmaster at vger.kernel.org and ask if they
> have logs records of why it is discarding your emails.
Thanks, I'll send them an email.