[lvc-project] [PATCH 5.10.y] arm64: topology: fix possible overflow in amu_fie_setup()

Greg KH gregkh at linuxfoundation.org
Mon Oct 17 12:32:06 MSK 2022


On Sun, Oct 16, 2022 at 11:21:38PM +0300, Sergey Shtylyov wrote:
> Commit d4955c0ad77dbc684fc716387070ac24801b8bca upstream.
> 
> cpufreq_get_hw_max_freq() returns max frequency in kHz as *unsigned int*,
> while freq_inv_set_max_ratio() gets passed this frequency in Hz as 'u64'.
> Multiplying max frequency by 1000 can potentially result in overflow --
> multiplying by 1000ULL instead should avoid that...
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Fixes: cd0ed03a8903 ("arm64: use activity monitors for frequency invariance")
> Signed-off-by: Sergey Shtylyov <s.shtylyov at omp.ru>
> Link: https://lore.kernel.org/r/01493d64-2bce-d968-86dc-11a122a9c07d@omp.ru
> Signed-off-by: Will Deacon <will at kernel.org>

Now queued up, thanks.

greg k-h



More information about the lvc-project mailing list