[lvc-project] [PATCH 5/5] [v3] wifi: mwifiex: drop BUG_ON from TX paths

Brian Norris briannorris at chromium.org
Tue Aug 8 22:58:10 MSK 2023


On Wed, Aug 02, 2023 at 07:07:19PM +0300, Dmitry Antipov wrote:
> In 'mwifiex_process_sta_txpd()' and 'mwifiex_process_uap_txpd()',
> replace 'BUG_ON()' with runtime check, and move all these checks
> to 'mwifiex_process_tx()'. This way, both callees may be converted
> to 'void', and the caller may be simplified as well.
> 
> Suggested-by: Brian Norris <briannorris at chromium.org>
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>
> ---
> v3: drop some overengineered bits, fix a few nits reported by
> checkpatch.pl, and reorder series by making this patch the last
> one, thus hopefully simplify the landing

Thanks, I think this version is pretty clear, concise, and an overall
improvement.

For the whole series (though you rightly carried my Acked-by on the
others already):

Acked-by: Brian Norris <briannorris at chromium.org>



More information about the lvc-project mailing list