[lvc-project] [PATCH] wifi: ath9k: simplify ar9003_hw_process_ini()

[Jeff Johnson]

On 8/23/2023 5:52 AM, Dmitry Antipov wrote:
> Since commit 8896934c1684 ("ath9k_hw: remove direct accesses to channel
> mode flags") changes 'ar9550_hw_get_modes_txgain_index()' so it never
> returns -EINVAL, and 'ar9561_hw_get_modes_txgain_index()' never returns
> negative value too, an extra check in 'ar9003_hw_process_ini()' may be
> dropped.

Can you change the return type of those two functions from int to u32 to 
further signify that they always return a valid index and never return a 
negative errno

> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>
> ---
>   drivers/net/wireless/ath/ath9k/ar9003_phy.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.c b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> index a29c11f944a5..4731e6618209 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> @@ -925,9 +925,6 @@ static int ar9003_hw_process_ini(struct ath_hw *ah,
>   			modes_txgain_index =
>   				ar9561_hw_get_modes_txgain_index(ah, chan);
>   
> -		if (modes_txgain_index < 0)
> -			return -EINVAL;
> -
>   		REG_WRITE_ARRAY(&ah->iniModesTxGain, modes_txgain_index,
>   				regWrites);
>   	} else {