[lvc-project] Patch "tty: n_gsm, remove duplicates of parameters" has been added to the 5.10-stable tree

[gregkh at linuxfoundation.org]

This is a note to let you know that I've just added the patch titled

    tty: n_gsm, remove duplicates of parameters

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     tty-n_gsm-remove-duplicates-of-parameters.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable at vger.kernel.org> know about it.


>From Ilia.Gavrilov at infotecs.ru Tue Dec 12 12:17:23 2023
From: Gavrilov Ilia <Ilia.Gavrilov at infotecs.ru>
Date: Tue, 12 Dec 2023 11:17:21 +0000
Subject: tty: n_gsm, remove duplicates of parameters
To: "stable at vger.kernel.org" <stable at vger.kernel.org>, Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Daniel Starke <daniel.starke at siemens.com>, Jiri Slaby <jirislaby at kernel.org>, Russ Gorby <russ.gorby at intel.com>, "linux-kernel at vger.kernel.org" <linux-kernel at vger.kernel.org>, "lvc-project at linuxtesting.org" <lvc-project at linuxtesting.org>, Jiri Slaby <jslaby at suse.cz>
Message-ID: <20231212111431.4064760-3-Ilia.Gavrilov at infotecs.ru>

From: Jiri Slaby <jslaby at suse.cz>

commit b93db97e1ca08e500305bc46b08c72e2232c4be1 upstream.

dp, f, and i are only duplicates of gsmld_receive_buf's parameters. Use
the parameters directly (cp, fp, and count) and delete these local
variables.

Signed-off-by: Jiri Slaby <jslaby at suse.cz>
Link: https://lore.kernel.org/r/20210302062214.29627-41-jslaby@suse.cz
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov at infotecs.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/tty/n_gsm.c |   13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2577,27 +2577,24 @@ static void gsmld_receive_buf(struct tty
 			      char *fp, int count)
 {
 	struct gsm_mux *gsm = tty->disc_data;
-	const unsigned char *dp;
-	char *f;
-	int i;
 	char flags = TTY_NORMAL;
 
 	if (debug & 4)
 		print_hex_dump_bytes("gsmld_receive: ", DUMP_PREFIX_OFFSET,
 				     cp, count);
 
-	for (i = count, dp = cp, f = fp; i; i--, dp++) {
-		if (f)
-			flags = *f++;
+	for (; count; count--, cp++) {
+		if (fp)
+			flags = *fp++;
 		switch (flags) {
 		case TTY_NORMAL:
-			gsm->receive(gsm, *dp);
+			gsm->receive(gsm, *cp);
 			break;
 		case TTY_OVERRUN:
 		case TTY_BREAK:
 		case TTY_PARITY:
 		case TTY_FRAME:
-			gsm_error(gsm, *dp, flags);
+			gsm_error(gsm, *cp, flags);
 			break;
 		default:
 			WARN_ONCE(1, "%s: unknown flag %d\n",


Patches currently in stable-queue which might be from Ilia.Gavrilov at infotecs.ru are

queue-5.10/tty-n_gsm-add-sanity-check-for-gsm-receive-in-gsm_receive_buf.patch
queue-5.10/tty-n_gsm-fix-tty-registration-before-control-channel-open.patch
queue-5.10/tty-n_gsm-remove-duplicates-of-parameters.patch