[lvc-project] [PATCH] usb: storage: sddr55: avoid integer overflow
Alan Stern
stern at rowland.harvard.edu
Mon Feb 6 23:17:05 MSK 2023
On Mon, Feb 06, 2023 at 11:04:54PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 2/3/23 11:48 PM, Alan Stern wrote:
> [...]
> >> We're possibly losing information by shifting an int.
> >> Fix it by adding the necessary cast.
> >
> > Nonsense. The card's _total_ capacity is no larger than 128 MB, so a
> > page address can't possibly overflow an int.
>
> Then the 'address' variables shouldn't be declared *unsigned long*, right?
> That should fix the SVACE's report as well. Would you accept such a patch?
Yes.
Alan Stern
More information about the lvc-project
mailing list