[lvc-project] [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus()

Leon Romanovsky leon at kernel.org
Mon Feb 20 11:31:30 MSK 2023


On Sun, Feb 19, 2023 at 06:22:25PM +0300, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking
> 
> Found by Security Code and Linux Verification
> Center (linuxtesting.org) with SVACE
> 
> Fixes: 57579f7629a3 ("bnx2: Use request_firmware()")
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s at gmail.com>
> ---
> changes v2:
> - bnx2_init_cpu_fw() and bnx2_init_cpus() are void
> - delete casts to void
> - remove check of bnx2_init_cpus() in bnx2_init_chip()
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro at nvidia.com>



More information about the lvc-project mailing list