[lvc-project] Патч для рецнзии

[Данила Чернецов]

Добрый день!
В рамках работ по статистическому анализу кода ядра linux-5.10.yперед 
отправкой в upstream, согласно рекомендациям, направляем вам на 
согласование патч по срабатыванию NULL_AFTER_DEREF: 
drivers/gpu/drm/amd/display/dc/core/dc.c:1411 
<https://lvc-svacer.ispras.ru/mode/review/project/83b681dd-c2b5-459d-80cc-359ff2a64935/branch/4739abc2-5b35-494c-9748-062208797cd3/snapshot/952a1137-9415-42e4-8f91-83c6169ede53/marker/eyJtYXJrZXJJRCI6ICIxOTlkMTk0NS0xMTgzLTQyMmItOWY0Ni1iM2QxOTgwMjQyZmYiLCAiZmlsZSI6ICIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NvcmUvZGMuYyJ9>Просим 
вас провести ревью и указать возможные недочеты.
Во вложении патчи для upstream 
(0002-drm-amd-display-remove-an-unnecessary-NULL-check.patch) и 
linux-5.10.y (0003-drm-amd-display-remove-an-unnecessary-NULL-check.patch).

С Уважением,
Данила Чернецов
АО "ИВК"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20230227/811b21f9/attachment.html>
-------------- next part --------------
From eb6afe56c3c36e96f36f6fb25a11d58bf3c92938 Mon Sep 17 00:00:00 2001
From: Danila Chernetsov <Chernetsov at ivk.ru>
To: Harry Wentland <harry.wentland at amd.com> 
Cc: Leo Li <sunpeng.li at amd.com> 
Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com> 
Cc: Alex Deucher <alexander.deucher at amd.com> 
Cc: "Christian König" <christian.koenig at amd.com> 
Cc: "Pan, Xinhui" <Xinhui.Pan at amd.com> 
Cc: David Airlie <airlied at gmail.com> 
Cc: Daniel Vetter <daniel at ffwll.ch> 
Cc: amd-gfx at lists.freedesktop.org 
Cc: dri-devel at lists.freedesktop.org 
Cc: linux-kernel at vger.kernel.org 
Cc: lvc-project at linuxtesting.org
Date: Wed, 8 Feb 2023 21:27:51 +0000
Subject: [PATCH 2/2] drm/amd/display: remove an unnecessary NULL check

The "pipe" pointer can't be NULL because it's dereferenced on the line
before.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Danila Chernetsov <Chernetsov at ivk.ru>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 0cb8d1f934d1..d3b850372eb3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1854,7 +1854,7 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c
 		for (k = 0; k < MAX_PIPES; k++) {
 			pipe = &context->res_ctx.pipe_ctx[k];
 
-			for (l = 0 ; pipe && l < context->stream_count; l++)  {
+			for (l = 0 ; l < context->stream_count; l++)  {
 				if (context->streams[l] &&
 					context->streams[l] == pipe->stream &&
 					dc->hwss.setup_stereo)
-- 
2.25.1
-------------- next part --------------
From 578ee1bbd6e37a9daa0a13d1428080722166f066 Mon Sep 17 00:00:00 2001
From: Danila Chernetsov <Chernetsov at ivk.ru>
To: Harry Wentland <harry.wentland at amd.com> 
Cc: Leo Li <sunpeng.li at amd.com> 
Cc: Alex Deucher <alexander.deucher at amd.com> 
Cc: "Christian König" <christian.koenig at amd.com> 
Cc: David Airlie <airlied at linux.ie> 
Cc: Daniel Vetter <daniel at ffwll.ch> 
Cc: amd-gfx at lists.freedesktop.org 
Cc: dri-devel at lists.freedesktop.org 
Cc: linux-kernel at vger.kernel.org 
Cc: lvc-project at linuxtesting.org
Date: Wed, 8 Feb 2023 21:18:13 +0000
Subject: [PATCH 3/3] drm/amd/display: remove an unnecessary NULL check

The "pipe" pointer can't be NULL because it's dereferenced on the line
before.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Danila Chernetsov <Chernetsov at ivk.ru>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 99887bcfada0..5852174dab03 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1408,7 +1408,7 @@ static enum dc_status dc_commit_state_no_check(struct dc *dc, struct dc_state *c
 		for (k = 0; k < MAX_PIPES; k++) {
 			pipe = &context->res_ctx.pipe_ctx[k];
 
-			for (l = 0 ; pipe && l < context->stream_count; l++)  {
+			for (l = 0 ; l < context->stream_count; l++)  {
 				if (context->streams[l] &&
 					context->streams[l] == pipe->stream &&
 					dc->hwss.setup_stereo)
-- 
2.25.1