[lvc-project] [PATCH] power: supply: Added check for negative values

[Sebastian Reichel]

Hi,

On Tue, Dec 06, 2022 at 06:11:23PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 12/6/22 10:17, Denis Arefev wrote:
> > Variable 'pirq', which may receive negative value
> > in platform_get_irq().
> > Used as an index in a function regmap_irq_get_virq().
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > Signed-off-by: Denis Arefev <arefev at swemel.ru>
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede at redhat.com>
> 
> Regards,
> 
> Hans

Thanks, queued to power-supply's fixes branch.

-- Sebastian

> 
> > ---
> >  drivers/power/supply/axp288_fuel_gauge.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> > index 148eb8105803..36c7039c99c2 100644
> > --- a/drivers/power/supply/axp288_fuel_gauge.c
> > +++ b/drivers/power/supply/axp288_fuel_gauge.c
> > @@ -640,6 +640,8 @@ static void fuel_gauge_init_irq(struct axp288_fg_info *info)
> >  
> >  	for (i = 0; i < AXP288_FG_INTR_NUM; i++) {
> >  		pirq = platform_get_irq(info->pdev, i);
> > +		if (pirq < 0)
> > +			continue;
> >  		info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
> >  		if (info->irq[i] < 0) {
> >  			dev_warn(&info->pdev->dev,
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20230102/481f4231/attachment.pgp>