[lvc-project] [PATCH net] can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate

Fedor Pchelkin pchelkin at ispras.ru
Sat Jan 14 20:35:46 MSK 2023


Hello,

On Fri, 10 Sep 2021 14:40:05 +0200, Oleksij Rempel wrote:
> Ok, I see, this warning makes sense only if session will actually be
> deactivated.
>
> Acked-by: Oleksij Rempel <o.rempel at pengutronix.de>
>
> Thank you!

As Ziyang Xuan stated, the patch was not applied to upstream.

Usage of WARN_ON_ONCE in this case is actually discouraged: it erroneusly
complains in a valid situation.

So the macro should be removed with the aforementioned patch. If it makes
some sense for debugging purposes, WARN_ON_ONCE can be replaced with
netdev_warn/netdev_notice but anyway discard of WARN_ON_ONCE.

--
Regards,

Fedor



More information about the lvc-project mailing list