[lvc-project] [PATCH] scsi: hpsa: fix allocation size for scsi_host_alloc()

Alexey Khoroshilov khoroshilov at ispras.ru
Tue Jan 17 13:35:54 MSK 2023


On 17.01.2023 12:56, Alexey V. Vissarionov wrote:
> On 2023-01-16 14:41:08 -0800, Bart Van Assche wrote:
> 
>  >> Fixes: b705690d8d16f708 ("[SCSI] hpsa: combine hpsa_scsi_detect
>  >> and hpsa_register_scsi")
>  > That seems incorrect to me. Shouldn't the Fixes tag be changed
>  > into the following?
>  > Fixes: edd163687ea5 ("[SCSI] hpsa: add driver for HP Smart Array
>  > controllers.")
> 
> % git blame -L 5853,+1 -- drivers/scsi/hpsa.c
> b705690d8d16f7081 (Stephen M. Cameron 2012-01-19 14:00:53 -0600 5853)
> 	sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));
> 
> Is anything wrong here?

Yes, this commit just moves

  sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));

from one function to another one.


edd163687ea5 ("[SCSI] hpsa: add driver for HP Smart Array controllers.")
is the correct commit introducing the bug.

--
Alexey






More information about the lvc-project mailing list