[lvc-project] [PATCH v2] nfc: change order inside nfc_se_io error path
Fedor Pchelkin
pchelkin at ispras.ru
Tue Mar 7 00:26:50 MSK 2023
cb_context should be freed on the error path in nfc_se_io as stated by
commit 25ff6f8a5a3b ("nfc: fix memory leak of se_io context in
nfc_genl_se_io").
Make the error path in nfc_se_io unwind everything in reverse order, i.e.
free the cb_context after unlocking the device.
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Signed-off-by: Fedor Pchelkin <pchelkin at ispras.ru>
---
v1->v2: remove 'no functional changes' statement from commit info
net/nfc/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 348bf561bc9f..b9264e730fd9 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1446,8 +1446,8 @@ static int nfc_se_io(struct nfc_dev *dev, u32 se_idx,
return rc;
error:
- kfree(cb_context);
device_unlock(&dev->dev);
+ kfree(cb_context);
return rc;
}
--
2.34.1
More information about the lvc-project
mailing list