[lvc-project] [PATCH] nfc: pn533: initialize struct pn533_out_arg properly
Fedor Pchelkin
pchelkin at ispras.ru
Thu Mar 9 19:10:25 MSK 2023
On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote:
>
> nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> It's probably not worth respinning, but I expect the preferred
> approach is (*completely untested!*)
>
> ...
> struct pn533_out_arg arg;
> ...
>
> arg.phy = phy;
>
That is much prettier, thanks for advice!
BTW, is reverse xmas tree ordering considered to be a general
recommendation for all new kernel patches?
More information about the lvc-project
mailing list