[lvc-project] [PATCH] power: supply: generic-adc-battery: remove redundant return code assignment

Anton Gusev aagusev at ispras.ru
Fri Mar 17 20:00:07 MSK 2023


Since any subsequent uses of ret reassign it first and PTR_ERR does not
have any effect on its own, this line has no effect and can be removed.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Anton Gusev <aagusev at ispras.ru>
---
 drivers/power/supply/generic-adc-battery.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
index 66039c665dd1..b51e5c4b36ff 100644
--- a/drivers/power/supply/generic-adc-battery.c
+++ b/drivers/power/supply/generic-adc-battery.c
@@ -285,7 +285,6 @@ static int gab_probe(struct platform_device *pdev)
 		adc_bat->channel[chan] = iio_channel_get(&pdev->dev,
 							 gab_chan_name[chan]);
 		if (IS_ERR(adc_bat->channel[chan])) {
-			ret = PTR_ERR(adc_bat->channel[chan]);
 			adc_bat->channel[chan] = NULL;
 		} else {
 			/* copying properties for supported channels only */
-- 
2.39.2




More information about the lvc-project mailing list