[lvc-project] [PATCH net-next v2] bnx2: remove deadcode in bnx2_init_cpus()

patchwork-bot+netdevbpf at kernel.org patchwork-bot+netdevbpf at kernel.org
Fri Mar 24 08:00:26 MSK 2023


Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba at kernel.org>:

On Wed, 22 Mar 2023 19:28:43 +0300 you wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> Now checking the value of the return value is misleading when reading
> the code. Path with error handling was deleted in 57579f7629a3
> ("bnx2: Use request_firmware()").
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking to improving readability.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] bnx2: remove deadcode in bnx2_init_cpus()
    https://git.kernel.org/netdev/net-next/c/4691720f509a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





More information about the lvc-project mailing list