[lvc-project] [PATCH] drm/sched: Remove redundant check
Luben Tuikov
luben.tuikov at amd.com
Fri May 19 16:37:08 MSK 2023
Thanks!
Reviewed-by: Luben Tuikov <luben.tuikov at amd.com>
Applied to drm-misc-fixes.
Regards,
Luben
On 2023-05-17 08:52, Vladislav Efanov wrote:
> The rq pointer points inside the drm_gpu_scheduler structure. Thus
> it can't be NULL.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c61cdbdbffc1 ("drm/scheduler: Fix hang when sched_entity released")
> Signed-off-by: Vladislav Efanov <VEfanov at ispras.ru>
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 8c183639603e..aea5a90ff98b 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -1141,9 +1141,6 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
> for (i = DRM_SCHED_PRIORITY_COUNT - 1; i >= DRM_SCHED_PRIORITY_MIN; i--) {
> struct drm_sched_rq *rq = &sched->sched_rq[i];
>
> - if (!rq)
> - continue;
> -
> spin_lock(&rq->lock);
> list_for_each_entry(s_entity, &rq->entities, list)
> /*
More information about the lvc-project
mailing list