[lvc-project] [PATCH] wifi: ath11k: drop NULL pointer check in ath11k_update_per_peer_tx_stats()

Jeff Johnson quic_jjohnson at quicinc.com
Wed Sep 6 19:29:24 MSK 2023


On 9/6/2023 2:36 AM, Dmitry Antipov wrote:
> Since 'user_stats' is a fixed-size array of 'struct htt_ppdu_user_stats'
> in 'struct htt_ppdu_stats', any of its member can't be NULL and so
> relevant check may be dropped.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>

Acked-by: Jeff Johnson <quic_jjohnson at quicinc.com>

> ---
>   drivers/net/wireless/ath/ath11k/dp_rx.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 62bc98852f0f..146201d8dba2 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -1388,9 +1388,6 @@ ath11k_update_per_peer_tx_stats(struct ath11k *ar,
>   	u8 tid = HTT_PPDU_STATS_NON_QOS_TID;
>   	bool is_ampdu = false;
>   
> -	if (!usr_stats)
> -		return;
> -
>   	if (!(usr_stats->tlv_flags & BIT(HTT_PPDU_STATS_TAG_USR_RATE)))
>   		return;
>   




More information about the lvc-project mailing list