[lvc-project] [PATCH 1/2] wifi: mwifiex: simplify PCIE write operations

[Brian Norris]

On Tue, Sep 19, 2023 at 04:27:59PM +0300, Dmitry Antipov wrote:
> Since 'mwifiex_write_reg()' just issues void 'iowrite32()',
> convert the former to 'void' and simplify all related users
> (with the only exception of 'read_poll_timeout()' which
> explicitly requires a non-void function argument).
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 290 +++++---------------
>  1 file changed, 66 insertions(+), 224 deletions(-)

Acked-by: Brian Norris <briannorris at chromium.org>

> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index 6697132ecc97..88f632b9dd93 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
...  
> +/* Non-void wrapper needed for read_poll_timeout(). */
> +static inline int
> +mwifiex_write_reg_rpt(struct mwifiex_adapter *adapter, int reg, u32 data)

This is kind of a weird name, but I don't have better suggestions. Maybe
it helps dissuade people from using it outside its very specific context
(where you have to read the comment to understand what "rpt" means).