[lvc-project] [PATCH] extcon: checking the function return code

[Krzysztof Kozlowski]

On 04/08/2024 15:08, Mikhail Lobanov wrote:
> This patch adds error handling for the return value of the max77693_muic_set_path function within

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


> the max77693_muic_probe function. The return value is checked to ensure that any error returned by
> max77693_muic_set_path is properly handled. If the function call fails, an error message is logged 
> and the probe function returns the error code.

Entire commit msg is useless. Please describe the bug instead you are
fixing.

After quick look, I don't see any issue being fixed except as usual
SVACE false positives.

Many people complained already on your "reports"...


Best regards,
Krzysztof