[lvc-project] [PATCH] netfilter: nfnetlink_log: remove unnecessary check in __build_packet_message()
Roman Smirnov
r.smirnov at omp.ru
Fri Aug 9 10:40:35 MSK 2024
skb->dev is always non-NULL, the check is unnecessary.
Remove it.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Signed-off-by: Roman Smirnov <r.smirnov at omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov at omp.ru>
---
net/netfilter/nfnetlink_log.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 134e05d31061..ee04a52eaf33 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -566,8 +566,7 @@ __build_packet_message(struct nfnl_log_net *log,
nla_put_be32(inst->skb, NFULA_MARK, htonl(skb->mark)))
goto nla_put_failure;
- if (indev && skb->dev &&
- skb_mac_header_was_set(skb) &&
+ if (indev && skb_mac_header_was_set(skb) &&
skb_mac_header_len(skb) != 0) {
struct nfulnl_msg_packet_hw phw;
int len;
--
2.43.0
More information about the lvc-project
mailing list