[lvc-project] [PATCH net] net: marvell: prestera: Remove unneeded check in prestera_port_create()

Aleksandr Mishin amishin at t-argos.ru
Wed Aug 28 16:26:06 MSK 2024


prestera_port_create() calls prestera_rxtx_port_init() and analyze its
return code. prestera_rxtx_port_init() always returns 0, so this check is
unneeded and should be removed.

Remove unneeded check to clean up the code.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Aleksandr Mishin <amishin at t-argos.ru>
---
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 63ae01954dfc..2d4f6d03b729 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -718,9 +718,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
 		}
 	}
 
-	err = prestera_rxtx_port_init(port);
-	if (err)
-		goto err_port_init;
+	prestera_rxtx_port_init(port);
 
 	INIT_DELAYED_WORK(&port->cached_hw_stats.caching_dw,
 			  &prestera_port_stats_update);
-- 
2.30.2




More information about the lvc-project mailing list