[lvc-project] [PATCH v3 3/3] net: sched: use RCU read-side critical section in taprio_dump()

Dmitry Antipov dmantipov at yandex.ru
Fri Aug 30 16:48:39 MSK 2024


On 8/30/24 4:02 PM, Alexander Lobakin wrote:

> Why did you invert this condition and introduced +1 indent level?

Just to reduce amount of labels and related gotos. After adding 'unlock'
at the end of RCU critical section, it was too much of them IMHO.

> The original code doesn't have nla_nest_cancel(), why was it added?

IIUC both original and new code has 'nla_nest_start_noflag()' and
'nla_nest_{end,chancel}()' calls balanced correctly.

Dmitry




More information about the lvc-project mailing list