[lvc-project] [PATCH 3/3] wifi: ath9k: simplify internal time management
Toke Høiland-Jørgensen
toke at toke.dk
Tue Dec 10 12:58:44 MSK 2024
Dmitry Antipov <dmantipov at yandex.ru> writes:
> Prefer 'ktime_t' over 'struct timespec64' for 'struct ath_chanctx' and
> 'struct ath_softc' timestamps, choose standard kernel time API over an
> ad-hoc math in 'chanctx_event_delta()' and 'ath9k_hw_get_tsf_offset()',
> adjust related users. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>
Nice cleanup! Just one formatting nit:
[...]
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index 2f137856a823..cf664a0dedaa 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -247,10 +247,8 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start)
> if (!sc->cur_chan->offchannel && start) {
> /* restore per chanctx TSF timer */
> if (sc->cur_chan->tsf_val) {
> - u32 offset;
> -
> - offset = ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_ts,
> - NULL);
> + u32 offset = ath9k_hw_get_tsf_offset
> + (sc->cur_chan->tsf_ts, 0);
This turned into a really odd line break. Let's just keep the variable
definition on its own line like it was before, so we can keep the
function call the way it is as well...
-Toke
More information about the lvc-project
mailing list