[lvc-project] [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean

[Johannes Berg]

On Thu, 2024-02-08 at 15:06 +0100, Arend van Spriel wrote:
> 
> settings->hidden_ssid has already been used above in following call:
> 
> 		err = brcmf_fil_iovar_int_set(ifp, "closednet",
> 					      settings->hidden_ssid);
> 
> So we pass the value as is to firmware using the same assumption, ie. 
> NL80211_HIDDEN_SSID_NOT_IN_USE. Is this not ABI thus very unlikely to 
> change?

The ABI won't change, that'd break all the users of nl80211 that use
this :-)

> @Johannes:
> Actually not quite understanding the reason for having this setting in 
> nl80211. hidden_ssid means SSID element length is zero, right?
> 

Well, there at least _were_ APs doing the correct SSID length but
setting all octets to zero ... Not sure that's still a thing though.

johannes