[lvc-project] [PATCH] brcmfmac: Remove unnecessary NULL-check.

Kalle Valo kvalo at kernel.org
Mon Feb 12 10:27:41 MSK 2024


Arend van Spriel <arend.vanspriel at broadcom.com> writes:

> On 2/11/2024 4:05 PM, Daniil Dulov wrote:
>> In this case req will never be NULL, so remove unnecessary check.
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Looks good to me, but when do we call things a "fix" and when is
> "improvement" more appropriate.
>
>> Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
> Reviewed-by: Arend van Spriel <arend.vanspriel at broadcom.com>

Yeah, this is not a fix and the Fixes tag should be removed.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the lvc-project mailing list