[lvc-project] [PATCH] net: sfp: remove redundant NULL check

Jakub Kicinski kuba at kernel.org
Wed Feb 14 04:26:25 MSK 2024


On Tue, 13 Feb 2024 13:43:57 +0100 Paolo Abeni wrote:
> On Sun, 2024-02-11 at 07:08 -0800, Daniil Dulov wrote:
> > bus->upstream_ops in sfp_register_bus() cannot be NULL. So remove
> > redundant NULL check.  
> 
> I'm unsure about that?!? in theory drivers could call
> sfp_bus_add_upstream()/phy_sfp_probe() with NULL ops, even it that very
> likely doesn't make any sense.
> 
> @Russel, @Andrew: WDYT?

Since Russell is AFK let me discard this instead of queuing.
We'll resurrect if any of the maintainers sends review tags or alike.



More information about the lvc-project mailing list