[lvc-project] [PATCH] can: softing: remove redundant NULL check

Simon Horman horms at kernel.org
Fri Feb 16 20:27:01 MSK 2024


On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
> In this case dev cannot be NULL, so remove redundant check.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
> Signed-off-by: Daniil Dulov <d.dulov at aladdin.ru>

Hi Daniil,

I am not sure that dev cannot be NULL.
But I do see that the code assumes it is not, and would crash if it is.
So I think that, functionally, your statement is correct.

	priv = netdev_priv(dev);
	card = priv->card;

Reviewed-by: Simon Horman <horms at kernel.org>



More information about the lvc-project mailing list