[lvc-project] [PATCH v2] wifi: brcmfmac: do not pass hidden SSID attribute as value directly

[Arend Van Spriel]

On February 22, 2024 1:29:57 PM Alexey Berezhok <a at bayrepo.ru> wrote:

> In 'brcmf_cfg80211_start_ap()', not assume that
> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
> an explicit check instead.  Use local
> variable 'closednet' to pass in function call and
> use for error message. Compile tested only.
>
> Addition for the following patch
>
>    commit f20073f50dfd1 ("wifi: brcmfmac: do not cast hidden SSID
>                           attribute value to boolean")

Thanks for the new revision. Although there was a remark about using 
string_choices.h instead of open coding 'val ? "enable" : "disable" ' I 
think that can be done driver wide. Pretty sure the are more instances of 
that. Maybe worth writing a coccinelle patch for that. So for this one...

Acked-by: Arend van Spriel <arend.vanspriel at broadcom.com>
> Signed-off-by: Alexey Berezhok <a at bayrepo.ru>
> ---
> .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c  | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4219 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20240222/3fc18738/attachment.bin>