[lvc-project] [PATCH] ACPI / PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()

Markus Elfring Markus.Elfring at web.de
Sat Jul 6 16:47:02 MSK 2024


> In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which
> is useless.

            because …?


> Fix this issue by removing unneeded check.

Another wording suggestion:
  Thus remove a redundant check (and …?).


…
> +++ b/drivers/acpi/pmic/tps68470_pmic.c
> @@ -376,7 +376,7 @@ static int tps68470_pmic_opregion_probe(struct platform_device *pdev)
>  	struct tps68470_pmic_opregion *opregion;
>  	acpi_status status;
>
> -	if (!dev || !tps68470_regmap) {
> +	if (!tps68470_regmap) {
>  		dev_warn(dev, "dev or regmap is NULL\n");
…

Would you like to adjust the passed string literal accordingly?

Regards,
Markus



More information about the lvc-project mailing list