[lvc-project] [PATCH 5.10 2/2] hugetlbfs: fix hugetlbfs_statfs() locking
Alexey Khoroshilov
khoroshilov at ispras.ru
Thu Jun 20 01:48:44 MSK 2024
Если это два патча, то почему у них одинаковый upstream hash и заголовки?
Если нет, то все правки лучше сделать в одном патче.
On 19.06.2024 22:56, Mikhail Ukhin wrote:
> Commit 4b25f030ae69ba710eff587cabb4c57cb7e7a8a1 upstream.
>
> After commit db71ef7 ("hugetlb: make free_huge_page irq safe"), the
> subpool lock should be locked with spin_lock_irq() and all call sites was
> modified as such, except for the ones in hugetlbfs_statfs().
>
> Link: https://lkml.kernel.org/r/20220429202207.3045-1-almasrymina@google.com
> Fixes: db71ef7 ("hugetlb: make free_huge_page irq safe")
> Signed-off-by: Mina Almasry <almasrymina at google.com>
> Reviewed-by: Mike Kravetz <mike.kravetz at oracle.com>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> Signed-off-by: Mikhail Ukhin <mish.uxin2012 at yandex.ru>
> ---
> ---
> fs/hugetlbfs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index bf3cda498962..b6440007116e 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1069,12 +1069,12 @@ static int hugetlbfs_statfs(struct dentry *dentry, struct kstatfs *buf)
> if (sbinfo->spool) {
> long free_pages;
>
> - spin_lock(&sbinfo->spool->lock);
> + spin_lock_irq(&sbinfo->spool->lock);
> buf->f_blocks = sbinfo->spool->max_hpages;
> free_pages = sbinfo->spool->max_hpages
> - sbinfo->spool->used_hpages;
> buf->f_bavail = buf->f_bfree = free_pages;
> - spin_unlock(&sbinfo->spool->lock);
> + spin_unlock_irq(&sbinfo->spool->lock);
> buf->f_files = sbinfo->max_inodes;
> buf->f_ffree = sbinfo->free_inodes;
> }
>
More information about the lvc-project
mailing list