[lvc-project] [PATCH] tg3: Remove residual error handling in tg3_suspend
Michael Chan
michael.chan at broadcom.com
Fri Mar 8 01:38:01 MSK 2024
On Thu, Mar 7, 2024 at 11:23 AM Nikita Kiryushin <kiryushin at ancud.ru> wrote:
>
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> Remove (now unreachable) code for simplification.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
> Signed-off-by: Nikita Kiryushin <kiryushin at ancud.ru>
The patch looks good to me. But I think we can go one step further
and change tg3_power_down_prepare() to a void function. Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4209 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20240307/8e5cdded/attachment.bin>
More information about the lvc-project
mailing list