[lvc-project] wifi: rt2x00: weird self-assignment in rt2800_loft_search()

[Dmitry Antipov]

On 3/25/24 17:28, Daniel Golle wrote:

> On Mon, Mar 25, 2024 at 04:21:40PM +0300, Dmitry Antipov wrote:
>> What's an intention behind a 'idxf[iorq] = idxf[iorq]'
>> self-assignment in 'rt2800_loft_search()'?
> 
> No matter what the potentially magic intention was, it should be
> removed, obviously ;)
> 
> You wanna send a patch?

Not sure. This doesn't look like a critical fix, and Kalle seems to be
constantly overloaded and has no resources to handle simple cleanups ([1]),
so it would be better if you just include this into your next major
driver update.

Dmitry

[1] https://lore.kernel.org/linux-wireless/87o7b7fjzp.fsf@toke.dk/T/#mab0c9f9641341575b2e07d0233157fa4b9f96a68