[lvc-project] [PATCH net-next v2] tg3: Remove residual error handling in tg3_suspend
Michael Chan
michael.chan at broadcom.com
Wed Mar 27 08:09:21 MSK 2024
On Tue, Mar 26, 2024 at 8:24 PM Jakub Kicinski <kuba at kernel.org> wrote:
>
> On Wed, 27 Mar 2024 08:14:30 +0530 Ratheesh Kannoth wrote:
> > > @@ -18090,7 +18090,6 @@ static int tg3_suspend(struct device *device)
> > > {
> > Please address Michael Chan's comment to make this function return type to "void"
> > instead of "int"
>
> It's used as a callback in SIMPLE_DEV_PM_OPS(), how would that work?
It won't work. I only requested to change tg3_power_down_prepare() to
void and it was done in v2:
https://lore.kernel.org/netdev/CACKFLinzJjqe0j4OFkcCV+FyH0JiUpnj3j2azZkGaC9jfvFXrQ@mail.gmail.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4209 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://linuxtesting.org/pipermail/lvc-project/attachments/20240326/12cb68c6/attachment.bin>
More information about the lvc-project
mailing list