[lvc-project] [PATCH] of: module: prevent NULL pointer dereference in vsnprintf()

Rob Herring robh at kernel.org
Thu Mar 28 01:04:31 MSK 2024


On Wed, 27 Mar 2024 19:52:49 +0300, Sergey Shtylyov wrote:
> In of_modalias(), we can get passed the str and len parameters which would
> cause a kernel oops in vsnprintf() since it only allows passing a NULL ptr
> when the length is also 0. Also, we need to filter out the negative values
> of the len parameter as these will result in a really huge buffer since
> snprintf() takes size_t parameter while ours is ssize_t...
> 
> Found by Linux Verification Center (linuxtesting.org) with the Svace static
> analysis tool.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov at omp.ru>
> 
> ---
> The patch is against the for-next branch of Rob Herring's linux-git repo...
> 
>  drivers/of/module.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Applied, thanks!




More information about the lvc-project mailing list