[lvc-project] [PATCH] wifi: brcmsmac: simplify wlc_phy_rxcal_radio_setup_nphy()
Arend van Spriel
arend.vanspriel at broadcom.com
Wed Oct 30 14:13:04 MSK 2024
On 10/29/2024 12:49 PM, Dmitry Antipov wrote:
> Since 'tx_rx_cal_radio_saveregs[]' of 'struct brcms_phy' is 'u16',
> 'pi->tx_rx_cal_radio_saveregs[2] & 0xF0) >> 8' is always zero, so
> a few duplicated snippets in 'wlc_phy_rxcal_radio_setup_nphy()'
> may be reduced to compile-time constant (in fact, the same thing is
> actually done by both gcc and clang I've tried). Compile tested only.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
Thanks, Dmitry
This was already reported earlier bij Colin (Ian) King. Can you agree to
add a Reported-by: tag?
As for the change it is true that it boils down to a constant, but I
doubt is that would be the intended behavior. I have to consult my
co-workers in radio/phy team.
Regards,
Arend
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>
> ---
> .../broadcom/brcm80211/brcmsmac/phy/phy_n.c | 44 ++-----------------
> 1 file changed, 4 insertions(+), 40 deletions(-)
More information about the lvc-project
mailing list