[lvc-project] [PATCH] usb: isp1760: increase buffer size to avoid overflow

Alexey V. Vissarionov gremlin at altlinux.org
Wed Apr 23 14:05:40 MSK 2025


Good ${greeting_time}!

On 2025-04-23 09:30:48 +0300, Fedor Pchelkin wrote:

 > On Wed, 23. Apr 02:00, Alexey V. Vissarionov wrote:
 >> isp1760_field_set() may access the udc->fields array beyond
 >> the size of DC_FIELD_MAX up to HC_FIELD_MAX, which is (now)
 >> bigger.
 > Where exactly does the problem manifest? There is no
 > comprehensible bug description here from you..
 > Though I guess isp1760_set_pullup() call site is concerned?

Yes, when called from isp1760_udc_init_hw()

+ When isp1760_udc_init_hw() calls isp1760_set_pullup(),

 > Please make sure to run your changes through checkpatch.pl and
 > the compiler first.

Mea culpa... Sent earlier version.

There should be only one warning on "Comparisons should place
the constant on the right side of the test" when comparing two
constants.

Updated patch follows.


-- 
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net



More information about the lvc-project mailing list