[lvc-project] [PATCH] usb: isp1760: fix set/clear pullup register field access

Rui Miguel Silva rui.silva at linaro.org
Thu Apr 24 12:17:05 MSK 2025


We need to access the register HW_OTG_CTRL_SET mapped¬ on hcd regmap
and not in the udc regmap region. Fix the call in isp1760_fields_set
from the isp1760_set_pullup to use the correct regmap fields set.

Reported-by: "Alexey V. Vissarionov" <gremlin at altlinux.org>
Fixes: 1da9e1c06873 ("usb: isp1760: move to regmap for register access")
Signed-off-by: Rui Miguel Silva <rui.silva at linaro.org>
---
 drivers/usb/isp1760/isp1760-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-core.c b/drivers/usb/isp1760/isp1760-core.c
index af88f4fe00d2..1eec4b21b54f 100644
--- a/drivers/usb/isp1760/isp1760-core.c
+++ b/drivers/usb/isp1760/isp1760-core.c
@@ -109,12 +109,12 @@ static int isp1760_init_core(struct isp1760_device *isp)
 
 void isp1760_set_pullup(struct isp1760_device *isp, bool enable)
 {
-	struct isp1760_udc *udc = &isp->udc;
+	struct isp1760_hcd *hcd = &isp->hcd;
 
 	if (enable)
-		isp1760_field_set(udc->fields, HW_DP_PULLUP);
+		isp1760_field_set(hcd->fields, HW_DP_PULLUP);
 	else
-		isp1760_field_set(udc->fields, HW_DP_PULLUP_CLEAR);
+		isp1760_field_set(hcd->fields, HW_DP_PULLUP_CLEAR);
 }
 
 /*
-- 
2.49.0




More information about the lvc-project mailing list