[lvc-project] [PATCH v2] hwmon: (asus-ec-sensors) add WARN_ONCE() on invalid sensor index

[Guenter Roeck]

On 4/29/25 04:30, Eugene Shalygin wrote:
>> If this is seen, it is an implementation error which needs to be fixed.
>> Returning an error to userspace will leave users annoyed but will not
>> result in a fix. The warning backtrace is warranted in this situation.
> 
> Thanks for the explanation! I'm still not convinced that such a
> generic error message (without the type and channel) can be of great

Feel free to suggest a better one. Maybe I misunderstood your earlier
concerns, but it seemed to me that you objected to having a message
in the first place, not to its contents.

Thanks,
Guenter

> help. Something serious needs to happen to trigger this error, like a
> hardware change, or a RAM failure... If the purpose of the message is
> only to grab attention, it could say that explicitly. But anyway,
> 
> Reviewed-by: Eugene Shalygin <eugene.shalygin at gmail.com>
> 
> Eugene