[lvc-project] [PATCH 5.10] tracing: Do not let histogram values have some modifiers

[Fedor Pchelkin]

On Mon, 09. Jun 15:39, Denis Arefev wrote:
> @@ -3705,6 +3705,15 @@ static int __create_val_field(struct hist_trigger_data *hist_data,
>  		goto out;
>  	}
>  
> +	/* Some types cannot be a value */
> +	if (hist_field->flags & (HIST_FIELD_FL_GRAPH | HIST_FIELD_FL_PERCENT |
> +				 HIST_FIELD_FL_BUCKET | HIST_FIELD_FL_LOG2 |
> +				 HIST_FIELD_FL_SYM | HIST_FIELD_FL_SYM_OFFSET |
> +				 HIST_FIELD_FL_SYSCALL | HIST_FIELD_FL_STACKTRACE)) {
> +		hist_err(file->tr, HIST_ERR_BAD_FIELD_MODIFIER, errpos(field_str));
> +		ret = -EINVAL;
> +	}
> +

Options: -Oline -j 16 W=1 C=1 ARCH=x86_64 CROSS_COMPILE=
CC: gcc (Debian 14.2.0-19) 14.2.0
Baseline building the tree: 4e0cf448dd47 ("tracing: Do not let histogram values have some modifiers")

../kernel/trace/trace_events_hist.c: In function '__create_val_field':
../kernel/trace/trace_events_hist.c:3709:34: error: 'HIST_FIELD_FL_GRAPH' undeclared (first use in this function); did you mean 'HIST_FIELD_FL_CPU'?
 3709 |         if (hist_field->flags & (HIST_FIELD_FL_GRAPH | HIST_FIELD_FL_PERCENT |
      |                                  ^~~~~~~~~~~~~~~~~~~
      |                                  HIST_FIELD_FL_CPU
../kernel/trace/trace_events_hist.c:3709:34: note: each undeclared identifier is reported only once for each function it appears in
../kernel/trace/trace_events_hist.c:3709:56: error: 'HIST_FIELD_FL_PERCENT' undeclared (first use in this function); did you mean 'HIST_FIELD_FL_STRING'?
 3709 |         if (hist_field->flags & (HIST_FIELD_FL_GRAPH | HIST_FIELD_FL_PERCENT |
      |                                                        ^~~~~~~~~~~~~~~~~~~~~
      |                                                        HIST_FIELD_FL_STRING
../kernel/trace/trace_events_hist.c:3710:34: error: 'HIST_FIELD_FL_BUCKET' undeclared (first use in this function); did you mean 'HIST_FIELD_FL_KEY'?
 3710 |                                  HIST_FIELD_FL_BUCKET | HIST_FIELD_FL_LOG2 |
      |                                  ^~~~~~~~~~~~~~~~~~~~
      |                                  HIST_FIELD_FL_KEY
make[3]: *** [../scripts/Makefile.build:286: kernel/trace/trace_events_hist.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [../scripts/Makefile.build:503: kernel/trace] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/pchelkin/linux-stable-rc-ci/linux-linux-5.10-lvc-next/Makefile:1837: kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:192: __sub-make] Error 2


>  	hist_data->fields[val_idx] = hist_field;
>  
>  	++hist_data->n_vals;
> -- 
> 2.43.0