[lvc-project] [PATCH] hwmon: (asus-ec-sensors) check sensor index in read_string()

Guenter Roeck linux at roeck-us.net
Fri May 2 06:07:57 MSK 2025


On Thu, Apr 24, 2025 at 11:26:54PM +0300, Alexei Safin wrote:
> Prevent a potential invalid memory access when the requested sensor
> is not found.
> 
> find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
> but its result was used without checking, which could lead to
> undefined behavior when passed to get_sensor_info().
> 
> Add a proper check to return -EINVAL if sensor_index is negative.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
> Signed-off-by: Alexei Safin <a.safin at rosa.ru>

Since we can't agree on warn or not or how, I decided to apply this
version after changing the error return value as suggested.

Guenter



More information about the lvc-project mailing list