[lvc-project] [PATCH] gfs2: eliminate unreachable code in gfs2_freeze_super()

Alexey Velichayshiy a.velichayshiy at ispras.ru
Sat Nov 1 12:55:27 MSK 2025


The general error check after gfs2_do_thaw() made the subsequent
specific error handlers for -EBUSY and -EIO unreachable. Remove
the redundant general check to ensure proper error handling
for specific cases while preserving the retry mechanism.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Alexey Velichayshiy <a.velichayshiy at ispras.ru>
---
 fs/gfs2/super.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 644b2d1e7276..03b407a925dc 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -750,8 +750,6 @@ static int gfs2_freeze_super(struct super_block *sb, enum freeze_holder who,
 		}
 
 		error = gfs2_do_thaw(sdp, who, freeze_owner);
-		if (error)
-			goto out;
 
 		if (error == -EBUSY)
 			fs_err(sdp, "waiting for recovery before freeze\n");
-- 
2.43.0




More information about the lvc-project mailing list