[lvc-project] [PATCH net] net: dsa: hellcreek: fix missing error handling in LED registration

Andrew Lunn andrew at lunn.ch
Thu Nov 13 17:08:18 MSK 2025


On Thu, Nov 13, 2025 at 04:57:44PM +0300, Pavel Zhigulin wrote:
> The LED setup routine registered both led_sync_good
> and led_is_gm devices without checking the return
> values of led_classdev_register(). If either registration
> failed, the function continued silently, leaving the
> driver in a partially-initialized state and leaking
> a registered LED classdev.
> 
> Add proper error handling
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Does it say anything about leaking leds?

> Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin at kaspersky.com>

Reviewed-by: Andrew Lunn <andrew at lunn.ch>

    Andrew



More information about the lvc-project mailing list